Make ESR compatible with the new ETOS kubernetes controller #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
andmat900
reviewed
Jul 23, 2024
projects/etos_suite_runner/src/etos_suite_runner/lib/esr_parameters.py
Outdated
Show resolved
Hide resolved
projects/etos_suite_runner/src/etos_suite_runner/lib/esr_parameters.py
Outdated
Show resolved
Hide resolved
t-persson
force-pushed
the
handle-controller
branch
from
df7c2b6 to
d59859d
Compare
t-persson
force-pushed
the
handle-controller
branch
from
e4d821c to
f1fd4bc
Compare
fredjn
requested changes
Sep 20, 2024
projects/etos_suite_runner/src/etos_suite_runner/lib/esr_parameters.py
Outdated
Show resolved
Hide resolved
projects/etos_suite_runner/src/etos_suite_runner/lib/esr_parameters.py
Outdated
Show resolved
Hide resolved
andmat900
reviewed
Nov 20, 2024
projects/etos_suite_runner/src/etos_suite_runner/lib/esr_parameters.py
Outdated
Show resolved
Hide resolved
andmat900
reviewed
Nov 20, 2024
The ESR shall work with the current way of running ETOS but should detect if it is running as a part of the ETOS kubernetes controller. I also removed the announcement events. This is not necessary, but they no longer provide any value.
The Environment provider can handle this by itself now
t-persson
force-pushed
the
handle-controller
branch
from
1eb6415 to
65b6c88
Compare
|
Had to force-push due to rebase |
This was referenced Nov 21, 2024
fredjn
reviewed
Nov 22, 2024
fredjn
reviewed
Nov 22, 2024
fredjn
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
eiffel-community/etos#242
Description of the Change
The ESR shall work with the current way of running ETOS but should detect if it is running as a part of the ETOS kubernetes controller.
I also removed the announcement events. This is not necessary, but they no longer provide any value.
Alternate Designs
I noticed a few environment variables set by the ETOS kubernetes controller have names that don't feel right.
I would love to update those, but I think I will leave that further on in the poc instead of now.
Possible Drawbacks
The ESR will be able to run in two different environments meaning that the risk of bugs is larger. I'll try to keep changes to the minimum in the ESR and will clean it up after the poc is done.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]